When he was turned to dust in Amy’s Choice. I thought it was one of the coolest ways that he died. Of course being erased from time is cool too but when I read this question the disintegrating Rory popped into my mind first.